-
Notifications
You must be signed in to change notification settings - Fork 67
Improved SRP and extract classes/methods for better modularity #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I have fixed the following,
Providing the updated changes of #86 below for your reference. Fixes
|
|
Hi @mohammedhashim790 |
|
Hello Prof. @tushartushar, I realized that there are common methods (addToSmells() and initialiseCodeSmell()) and a variable (smells) used in both Implementation and Design Smell Detectors. Hence, I created a new class called CodeSmellDetector that inherits these identifiers, allowing them to be used for both types of Smell Detectors. Additionally, I applied an unfactored hierarchy to the smell detectors since they are unique in implementation but share common properties and methods with different implementations. Please let me know your thoughts. Would be happy to know about it. Screenshot for reference.
|
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this.
|
Hi @mohammedhashim790 |
Hello Prof. @tushartushar , I removed the Thanks, |
|
Thanks @mohammedhashim790 |
Hello Prof. @tushartushar , Due to refactoring of FileNames and paths, the tests failed. The build failure has been fixed and the following changes were done. Fixes
All tests have successfully passed the required stage, and I've attached the report for your reference. Let me know if you need any further updates!
|


Hello ,
I have made the following changes in DesigniteJava.
readFileToString,listFilesFromFolder,listFilesto FileManager in the application.