Skip to content

feat(server): Add commit version significance#2308

Open
Vampire wants to merge 1 commit into
mainfrom
vampire/commit-version-significance
Open

feat(server): Add commit version significance#2308
Vampire wants to merge 1 commit into
mainfrom
vampire/commit-version-significance

Conversation

@Vampire

@Vampire Vampire commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Vampire commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator Author

Vampire commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator Author

Still missing tests and docs, so still in Draft, but the production changes should be fine already to add the commit version significance.
You specify the normal version in the workflow script, but it writes out the commit id as version and the version as comment.

If no consistency check is done, it just runs with the old commit id.

If a consistency check it done, it fails the consistency check if the version points to another commit id, so this should only be used with concrete non-changeable versios, not with v1, but v1.2.3.

This also works properly with Renovate, as Renovate will update the commit id in the YAML and the version in the workflow script (if you configured it to do both chagnes in one PR) and it will build successfully, I tried locally.

@Vampire
Vampire force-pushed the vampire/fix-prefetching branch from 4a77e9d to 933b1aa Compare April 25, 2026 21:43
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch 4 times, most recently from 506987c to 96a2d88 Compare April 25, 2026 22:55
@Vampire
Vampire marked this pull request as ready for review April 25, 2026 22:55

Vampire commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, I think now it is also ready :-)

@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from 96a2d88 to deb8686 Compare April 26, 2026 01:12
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from deb8686 to ce0b00d Compare April 27, 2026 10:43
@Vampire
Vampire force-pushed the vampire/fix-prefetching branch 2 times, most recently from 5b6c090 to be17b5c Compare May 4, 2026 08:55
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch 2 times, most recently from aae2ea3 to ba97651 Compare May 4, 2026 11:41
@Vampire
Vampire force-pushed the vampire/fix-prefetching branch from be17b5c to a8b12c5 Compare May 4, 2026 11:41
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from ba97651 to 3797c81 Compare June 5, 2026 14:06
@Vampire
Vampire force-pushed the vampire/fix-prefetching branch from a8b12c5 to 79ad715 Compare June 5, 2026 14:06
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from 3797c81 to eb91d92 Compare June 9, 2026 11:19
@Vampire
Vampire force-pushed the vampire/fix-prefetching branch from 79ad715 to b221288 Compare June 9, 2026 11:19
Base automatically changed from vampire/fix-prefetching to main June 9, 2026 14:36
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from eb91d92 to 16c5a25 Compare June 9, 2026 14:48
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from 16c5a25 to 5695a19 Compare June 18, 2026 14:21
@Vampire
Vampire force-pushed the vampire/commit-version-significance branch from 5695a19 to 6273657 Compare June 29, 2026 08:27
@file:DependsOn("actions:setup-python___commit_lenient:v6.0.0__e797f83bcb11b83ae66e0230d6156d7c80228e7c")

// Action version pinned to a commit.
@file:DependsOn("actions:github-script___commit:v9.0.0")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's a good foundation for what we need, but the design doc for this feature specifies a slightly different API: https://github.com/typesafegithub/design-docs/blob/main/2025-04-27%20Enhancements%20to%20referring%20to%20actions%20by%20commit%20hash.md. So I wouldn't skip specifying commit ID if the user uses ___commit because the idea is to cross-check the version and the commit ID - they should match.

However, what you proposed in this PR is also an interesting approach. Maybe we could expose it under ___commit_infer or sth?

I'd also like to ask for adding consuming an action this way to some tests that surface how the YAML looks like, so likely to .github/workflows/end-to-end-tests.main.kts. I know the tests for ___commit_lenient are missing - my bad, they should be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants