-
Notifications
You must be signed in to change notification settings - Fork 21
Restrict tf turn to correct supercon #4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
19
commits into
main
Choose a base branch
from
restrict_tf_turn_to_correct_supercon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
769a976
Restrict TF coil turn calculations to cable superconductors only
chris-ashe bd75571
Initialize conductor parameters in SuperconductingTFData with default…
chris-ashe be73adf
Refactor CROCOSuperconductingTFCoil to streamline superconductor prop…
chris-ashe 82a45a1
Refactor CROCOSuperconductingTFCoil to optimize critical current calc…
chris-ashe 5d4f1b6
Enhance TF coil plots by adding critical current density and field in…
chris-ashe 5a3db89
Add output for peak inboard toroidal field with ripple in Superconduc…
chris-ashe e5f5ad9
Add copper area calculations and update related attributes in CROCOSu…
chris-ashe b51acb2
Refactor CROCOSuperconductingTFCoil to remove unused helium area calc…
chris-ashe c552f9c
Refactor CROCOSuperconductingTFCoil to update conductor area calculat…
chris-ashe 490deca
Refactor TF coil variables to rename conductor width to conduit full …
chris-ashe f157859
Refactor SuperconductingTFData and related tests to rename conductor …
chris-ashe 78d4af5
Refactor TFData and SuperconductingTFCoil to clarify mass calculation…
chris-ashe df3a01b
Update tests for ST to use croco turn type for tapes
chris-ashe a5f6d00
Add strain calculation and superconductor temperature margin logic in…
chris-ashe 4fe38e1
Add mapping for obsolete variable 't_conductor' to 'dx_tf_turn_condui…
chris-ashe 8a9bd72
Remove outdated comments regarding critical current density in CICCSu…
chris-ashe 5a7bce8
Refactor code structure for improved readability and maintainability
chris-ashe 30d2981
Enhance CICC and CroCo TF coil area calculations and add new data str…
chris-ashe b1b17ca
Update test values to try and align with previous solution
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -814,34 +814,34 @@ def hijc_rebco( | |
| # finding A(T); constants based on a Newton polynomial fit to pubished data | ||
| a_t = a_0 + (u * temp_conductor**2) + (v * temp_conductor) | ||
|
|
||
| # Critical current density (A/m2) | ||
| # Critical current | ||
| # In the original formula bcrit must be > bmax to prevent NaNs. | ||
| # However, negative jcrit is permissible (I think). | ||
| # So when bcrit < bmax, I reverse the sign of the bracket, | ||
| # giving a negative but real value of jcrit. | ||
|
|
||
| if b_critical > b_conductor: | ||
| j_critical = ( | ||
| cur_critical = ( | ||
| (a_t / b_conductor) | ||
| * b_critical**b | ||
| * (b_conductor / b_critical) ** p | ||
| * (1 - b_conductor / b_critical) ** q | ||
| ) | ||
| else: | ||
| j_critical = ( | ||
| cur_critical = ( | ||
| (a_t / b_conductor) | ||
| * b_critical**b | ||
| * (b_conductor / b_critical) ** p | ||
| * (b_conductor / b_critical - 1) ** q | ||
| ) | ||
|
|
||
| # Jc times HTS area: default area is width 4mm times HTS layer thickness 1 um, | ||
| # Critical current times HTS area: default area is width 4mm times HTS layer thickness 1 um, | ||
| # divided by the tape area to provide engineering Jc per tape,! | ||
| # A scaling factor of 0.4 used to be applied below to assume the difference | ||
| # between tape stacks and CORC cable layouts. | ||
|
|
||
| j_critical = ( | ||
| j_critical | ||
| cur_critical | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a bit confused by these units. So if the parameterisation of the critical surface gives a current and then we scale it by the tape size to get a current. The units are still Amps when you assign |
||
| * (dr_hts_tape * dx_hts_tape_rebco) | ||
| / (dr_hts_tape * dx_hts_tape_total) | ||
| ) | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.