Repository navigation
fix: trufflehog scans excluded files locally - #286
Merged
gabelton merged 4 commits intoNov 19, 2026
Merged
Conversation
Signed-off-by: BIST pre-commit check
Signed-off-by: BIST pre-commit check
Signed-off-by: BIST pre-commit check
sumau
reviewed
Nov 19, 2026
Contributor
|
Heya @gabelton thanks for raising this I've made one suggestion :-) |
sumau
approved these changes
Nov 19, 2026
Co-authored-by: Soumaya Mauthoor <soumaya.mauthoor@businessandtrade.gov.uk>
gabelton
deleted the
fix/trufflehog-still-scans-excluded-files-locally
branch
November 19, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BIST pre-commit check
Description
The current trufflehog logic works in the context of GH actions where all files are scanned and those in the exclusions file excluded, but when a subset of those files are scanned locally as part of the pre-commit hook the exclusion logic isn't working.
Contributors
Let's acknowledge the people who contributed to the work.
Type of change
How this has been tested
Please describe the tests that you ran to verify your changes.
If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced.
Checklist
Reviewer Checklist