Update UUID parameter types in ValidatorJSAsserts interface#288
Open
jorgegoncalves99 wants to merge 1 commit into
Open
Update UUID parameter types in ValidatorJSAsserts interface#288jorgegoncalves99 wants to merge 1 commit into
jorgegoncalves99 wants to merge 1 commit into
Conversation
jorgegoncalves99
force-pushed
the
support/uuid-assert-numeric-version
branch
from
c575767 to
1adad77
Compare
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated TypeScript definition still omits the explicitly supported 'all' UUID version, leaving the types slightly out of sync with runtime behavior.
Pull request overview
This PR updates the public TypeScript surface for the uuid() assert so consumers can pass UUID versions as numeric literals (in addition to the existing string literals), and expands the UUID assert tests to cover “stringified” numeric versions.
Changes:
- Updated
ValidatorJSAsserts.uuid()type signature to accept3 | 4 | 5 | 7(numeric literal versions) in addition to'3' | '4' | '5' | '7'. - Added test cases ensuring stringified numeric versions (e.g.
'3','4') are accepted.
File summaries
| File | Description |
|---|---|
| test/asserts/uuid-assert.test.js | Adds passing test cases for stringified UUID version inputs. |
| src/types/index.d.ts | Extends the uuid() TypeScript signature to allow numeric UUID version literals. |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add numeric versions to the uuid assert interface. And improved test cases to test both stringified numbers and the numeric versions being passed.