Repository navigation
feat: add one-password and secretReference - #107
Merged
arpit-bruno merged 4 commits intoNov 3, 2026
Merged
arpit-bruno merged 4 commits into
arpit-bruno merged 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 1536ad0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
prateek-bruno
marked this pull request as draft
October 19, 2026 19:32
sanish-bruno
left a comment
sanish-bruno
left a comment
There was a problem hiding this comment.
LGTM! I guess we will need to bump the @opencollection/types package version, either in this PR, or another PR @prateek-bruno cc: @bijin-bruno
Author
|
@sanish-bruno I would like to do it in this one only, so tests can run properly as well. |
prateek-bruno
marked this pull request as ready for review
November 2, 2026 12:17
prateek-bruno
force-pushed
the
feat/add-one-password-integration
branch
from
November 2, 2026 12:24
c19660b to
1b2e60f
Compare
- Moved the SECRET_POINTER_FIELD mapping to a new constant in environment.ts. - Introduced externalSecretPointer function to retrieve the appropriate pointer field based on the external secret type. - Updated EnvironmentsView to utilize the new externalSecretPointer function for cleaner code. - Enhanced unit tests to validate the pointer field retrieval for various secret managers.
arpit-bruno
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to opencollection-dev/opencollection#164
Show 1Password external secrets in the playground: the secret reference and a "1Password" label
Also upgrades opencollection to 0.15.0