Skip to content

Conversation

@abnegate
Copy link
Member

@abnegate abnegate commented Feb 13, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved boolean value handling in database create and update operations. Boolean values are now processed more consistently across different database backends for better reliability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

Updated boolean binding logic in the SQL adapter to use a database-agnostic method getSupportForIntegerBooleans() instead of a Postgres-specific check. Boolean values are now conditionally cast to integers before binding in both document creation and update operations based on adapter support.

Changes

Cohort / File(s) Summary
SQL Adapter Boolean Binding
src/Database/Adapter/SQL.php
Refactored boolean binding logic in createDocuments and updateDocuments methods to use getSupportForIntegerBooleans() for determining whether to cast booleans to integers, replacing previous Postgres-specific check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A boolean hops with grace so fine,
No longer bound to Postgres' line,
Adapter's choice now sets the way,
Cast or pass—adapt each day! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix adapter check' is vague and generic. While it references an actual change (adapter check logic), it lacks specificity about what aspect of the adapter is being fixed. Use a more descriptive title that specifies which adapter check is being fixed, such as 'Use getSupportForIntegerBooleans() for boolean binding check' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-pg-check

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abnegate abnegate merged commit 1530a1c into main Feb 13, 2026
18 checks passed
@abnegate abnegate deleted the fix-pg-check branch February 13, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant