Skip to content

install: use portable strip wrappers in tests - #13575

Open
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:install-strip-test-android
Open

install: use portable strip wrappers in tests#13575
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:install-strip-test-android

Conversation

@wtcpython

Copy link
Copy Markdown
Contributor

Fixes #13160.

The successful install --strip tests depended on a system strip binary and objdump, so they were disabled on Android and macOS x86_64.

Use executable POSIX shell wrappers as the strip programs and verify that the installed target is emptied. This keeps both the default lookup and explicit --strip-program paths covered without platform-specific binary dependencies.

@codspeed-hq

codspeed-hq Bot commented Jul 26, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 337 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 24.1 ms 24.9 ms -3.05%
Simulation du_all_wide_tree[(5000, 500)] 16.9 ms 16.2 ms +4.06%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wtcpython:install-strip-test-android (f52bb4d) with main (b0a6096)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_install.rs: replace strip binary with "truncate -s 0" for Android

1 participant