fix: nightly clippy redundant else block lint by HackingRepo · Pull Request #13601 · uutils/coreutils

HackingRepo · 2026-07-27T11:05:32Z

we saw that when doing cargo clippy locally

warning: redundant else block
   --> src/bin/coreutils.rs:140:6
    |
140 |       } else {
    |  ______^
141 | |         // GNU just fails, but busybox tests needs usage
142 | |         // todo: patch the test suite instead
143 | |         if binary_as_util.ends_with("box") {
...   |
148 | |         process::exit(1);
149 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
help: remove the `else` block and move the contents out
    |
140 ~     }
141 +     // GNU just fails, but busybox tests needs usage
142 +     // todo: patch the test suite instead
143 +     if binary_as_util.ends_with("box") {
144 +         usage(&utils, binary_as_util);
145 +     } else {
146 +         let _ = writeln!(io::stderr(), "coreutils: missing argument");
147 +     }
148 +     process::exit(1);

@cakebaker

Hi, @cakebaker we saw that when doing cargo clippy locally ```rust warning: redundant else block --> src/bin/coreutils.rs:140:6 | 140 | } else { | ______^ 141 | | // GNU just fails, but busybox tests needs usage 142 | | // todo: patch the test suite instead 143 | | if binary_as_util.ends_with("box") { ... | 148 | | process::exit(1); 149 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else help: remove the `else` block and move the contents out | 140 ~ } 141 + // GNU just fails, but busybox tests needs usage 142 + // todo: patch the test suite instead 143 + if binary_as_util.ends_with("box") { 144 + usage(&utils, binary_as_util); 145 + } else { 146 + let _ = writeln!(io::stderr(), "coreutils: missing argument"); 147 + } 148 + process::exit(1); ```

sylvestre · 2026-07-27T11:08:24Z

Could you please add this in the ci too?

sylvestre · 2026-07-27T11:29:23Z

we already have .github/workflows/code-quality.yml
but we didn't catch this case
so, just extend it to catch it

HackingRepo · 2026-07-27T11:30:27Z

ah ok

I delete it by mistake

codspeed-hq · 2026-07-27T11:48:23Z

Merging this PR will regress 1 benchmark

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 339 untouched benchmarks
🆕 3 new benchmarks
⏩ 46 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`uniq_check_chars[(10000, "1")]`	14.4 ms	14.9 ms	-3.24%
⚡	Memory	`timeout_quick_exit`	79 KB	16.2 KB	×4.9
⚡	Memory	`timeout_enforced`	19.4 KB	16.5 KB	+17.81%
🆕	Memory	`timer_expiry_latency[0.001]`	N/A	79.9 KB	N/A
🆕	Memory	`timer_expiry_latency[0.005]`	N/A	17 KB	N/A
🆕	Memory	`timer_expiry_latency[0.02]`	N/A	17 KB	N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing HackingRepo:patch-6 (abc9fca) with main (9d0c43a)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

HackingRepo · 2026-07-27T11:51:09Z

@sylvestre i used cargo nightly that why, because new lints introduced

HackingRepo · 2026-07-27T11:52:43Z

@sylvestre can we add nightly tests too or no?

sylvestre · 2026-07-27T11:53:06Z

ok, please revert the change then :)
thanks

Ah, i misunderstond, so i need revoke only the run clippy script that change needs to be keeped

HackingRepo · 2026-07-27T11:59:01Z

ok now done

xtqqczze · 2026-07-27T12:14:24Z

+            validation::unrecognized_option(binary_as_util, &util_os);
        }
-        process::exit(1);
+        validation::not_found(&util_os);


The change seems to be sound, but perhaps somewhat confusing as you now need to understand that validation::not_found etc exits the process to understand the control flow.

yes you are right

Actually not_found returns the never type, so the behaviour can be deduced from this.

xtqqczze

why has validation::not_found been removed?

HackingRepo · 2026-07-27T12:23:27Z

ah ok, i will revert it

github-actions · 2026-07-27T13:03:22Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/pid-pipe (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)

HackingRepo · 2026-07-27T13:30:08Z

@cakebaker and @sylvestre can you merge that>

HackingRepo added 3 commits July 27, 2026 07:14

Add cargo clippy ci new job

e72a4d0

fix: use git strip whitespace to strip whitespaces from the workflow

174ced0

try using --all-features

c163bbe

HackingRepo added 3 commits July 27, 2026 07:31

delete the new clippy job id we already have one

0afc456

fix: extend run clippy script

764720c

fix: restore cicd.yml

5f37735

I delete it by mistake

HackingRepo added 3 commits July 27, 2026 07:55

fix: revert coreutils.rs

33c3269

revert run clippy to normal

d82d123

fix: keep coreutils.rs clippy fix

5815f57

Ah, i misunderstond, so i need revoke only the run clippy script that change needs to be keeped

HackingRepo changed the title ~~fix: clippy redundant else block~~ fix: nightly clippy redundant else block lint Jul 27, 2026

xtqqczze reviewed Jul 27, 2026

View reviewed changes

fix: keep process exit for clarity

0b4047d

HackingRepo requested a review from xtqqczze July 27, 2026 12:18

xtqqczze suggested changes Jul 27, 2026

View reviewed changes

fix: revert validation not found

abc9fca

sylvestre merged commit 4855c67 into uutils:main Jul 28, 2026
160 of 162 checks passed

HackingRepo deleted the patch-6 branch July 28, 2026 07:37

Uh oh!

Uh oh!

Conversation

HackingRepo commented Jul 27, 2026

Uh oh!

sylvestre commented Jul 27, 2026

Uh oh!

sylvestre commented Jul 27, 2026

Uh oh!

HackingRepo commented Jul 27, 2026

Uh oh!

codspeed-hq Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will regress 1 benchmark

Performance Changes

Footnotes

Uh oh!

HackingRepo commented Jul 27, 2026

Uh oh!

HackingRepo commented Jul 27, 2026

Uh oh!

sylvestre commented Jul 27, 2026

Uh oh!

HackingRepo commented Jul 27, 2026

Uh oh!

xtqqczze Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HackingRepo Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

xtqqczze Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

xtqqczze left a comment

Choose a reason for hiding this comment

Uh oh!

HackingRepo commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

HackingRepo commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq Bot commented Jul 27, 2026 •

edited

Loading

xtqqczze Jul 27, 2026 •

edited

Loading

HackingRepo commented Jul 27, 2026 •

edited

Loading