basenc: add benchmark - #14022
Merged
Merged
Conversation
sylvestre
reviewed
Aug 19, 2026
myunbin
force-pushed
the
basenc-buf32k-bench
branch
from
August 19, 2026 08:58
8626e68 to
566f2ff
Compare
sylvestre
changed the title
Contributor
|
Note that CodSpeed does not measure time by syscalls. |
Contributor
Author
|
Wasn’t aware of that. Would it make sense to add CodSpeed walltime benchmarks to CI for I/O-bound tasks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #13885 .
Base16 encoding currently writes output in small chunks(~2 KiB).
Buffer these writes with a 32 KiB
BufWriterto reduce the number of write system calls.Benchmarks for
/dev/nulland regular-file output are also included.However, I kept input buffer at 8 KiB. It is shared by all formats, including Base32 and 64. Increasing it would also increase their memory usage. I can set it to 32 KiB, as in #13885, if preferred.
Thanks!