Cleanup: code style conventions, alphabetization, and file organization#178
Closed
Cleanup: code style conventions, alphabetization, and file organization#178
Conversation
Also alphabetize all i18n JSON keys (top-level sections and nested keys) in en.json and en.d.json.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Sort export lists alphabetically in barrel files and UI component trailing exports for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Sort SocialPlatform and MenuItemType union members alphabetically. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Replace all imports from @/components/product-card (barrel) with direct imports from the specific source files: primitives, product-card, and quick-add. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Document house style conventions: alphabetized exports/keys, no barrel files, client boundary placement, naming, Tailwind patterns. Wrapped in <!-- BEGIN:vercel-shop-style --> comments so downstream users can remove if they disagree with the choices. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Explain the BEGIN/END marker pattern, why it exists (safe upgrades, easy removal), and what each shipped block contains. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Keep sub-components in the same file as their consumer unless they need different directives. Do not create primitives.tsx by default. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Rename product-card/primitives.tsx to components.tsx. Update AGENTS.md file organization guidance: use components.tsx for directive-free sub-components, client-components.tsx for client, server-components.tsx for server. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
laugharn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.ts) and use direct importsprimitives.tsxtocomponents.tsxand establish naming convention for split files<!-- BEGIN:vercel-shop-style -->code style block toAGENTS.mddocumenting conventions: alphabetization, no barrel files, client boundary placement, file organization, naming, Tailwind patternsusing-a-coding-agent.mdx)Test plan
pnpm formatpasses cleanpnpm lintpasses with no new errorspnpm buildsucceeds🤖 Generated with Claude Code