Skip to content

feat(core): environments devtools config #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
webfansplz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Draft

feat(core): environments devtools config #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { isObject } from './utils'

export interface DevToolsConfig extends Partial<StartOptions> {
enabled: boolean
/**
* Vite environments to enable DevTools for. Defaults to all environments.
*/
environments?: string[]
Comment thread
webfansplz marked this conversation as resolved.
Copy link
Copy Markdown
Member

@antfu antfu Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the implemeation of using it?

Copy link
Copy Markdown
Member Author

@webfansplz webfansplz Apr 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be used in the Vite repo. See: vitejs/vite#22290

Copy link
Copy Markdown
Member

@antfu antfu Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be controlled by the plugin (here) instead in the Vite repo. I think the less coupling with the Vite repo the better.

Copy link
Copy Markdown
Member Author

@webfansplz webfansplz Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Most of the current Vite core integration is handled on the DevTools side. But the check for enabling the Rolldown debug log (https://github.com/vitejs/vite/blob/main/packages/vite/src/node/config.ts#L2071) — which is also where most of the build analysis time is spent — happens in Vite core. Given the current setup, where standalone DevTools is launched during Vite core’s build time, this part also seems like it has to be handled in Vite core.

/**
* Disable client authentication.
*
Expand Down
Loading