feat(core): vite integration plugin & environments config #300
Open
webfansplz wants to merge 2 commits intomainfrom
Open
feat(core): vite integration plugin & environments config #300webfansplz wants to merge 2 commits intomainfrom
webfansplz wants to merge 2 commits intomainfrom
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new public “integration” entrypoint to @vitejs/devtools intended to integrate DevTools into Vite’s build flow (and enable Rolldown devtools output), alongside a small refactor of DevTools config normalization.
Changes:
- Add
./integrationpackage export + newsrc/integration.tsentry for consumers. - Introduce
DevToolsIntegration()Vite plugin (build-only) to enablebuild.rolldownOptions.devtoolsand start DevTools. - Add
resolveDevToolsConfig()(and deprecatenormalizeDevToolsConfig()) to normalize/merge DevTools config inputs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/tsdown.config.ts | Adds build entry for the new integration entrypoint. |
| packages/core/src/node/plugins/integration.ts | New Vite plugin that enables Rolldown devtools options and starts DevTools during build. |
| packages/core/src/node/config.ts | Adds resolveDevToolsConfig() + host normalization helper; deprecates old normalizer. |
| packages/core/src/integration.ts | New public re-export entrypoint for the integration plugin. |
| packages/core/package.json | Exposes ./integration in the package exports map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9795ddd to
f66b9c6
Compare
21ee231 to
9115b5a
Compare
9115b5a to
0cacb1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be related to #296 (comment) and vitejs/vite#22312