[PATCH]: recognize NixOS Linux

[jagajaga]

No description provided.

[wmertens]

I wonder why VMWare thinks it's ok to completely ignore work done for them for free by volunteers…

[vmwclabot]

@jagajaga, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[csamsel]

assuming the existance of /etc/os-release implies a specific distribution (in the case NixOS) is wrong. It's not distribution specific, it's specific by LSB and available on almost all distributions.

[jagajaga]

@csamsel so who do you suggest to get that it is a NixOS?

[csamsel]

First of all, if you ask me, the OS recognition needs a complete rewrite, it is beyond repairable.

I never heard of NixOS, so i dont know anything about it. But the patch you suggested would break common distributions because the if/then/else around line 617 would match on /etc/os-release before e.g. Ubuntu and therefore recognize Ubuntu as NixOS.

If you are a NixOS developer the most simple way would probably to supply a patch to open-vm-tools in the respective package manager.

[jagajaga]

@wmertens what do you think?

[wmertens]

I agree that claiming os-release for NixOS is a bit greedy :) We could move the check to the bottom of the array.

The correct solution is to implement #33… /etc/os-release is the only attempt at standardizing this problem that I know of. So this file should be parsed first, and only if it is missing should the old code run.

@csamsel we do indeed have this patch in NixOS so for our use cases this is mostly worked around. Not pretty though, and note that our builds are also used on other OSes via NixPkgs.

[vmwclabot]

@jagajaga, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

[copumpkin]

@jagajaga ping 😄 it would be great to get this merged in so we can stop patching it on the distro side

[jagajaga]

We have received your signed contributor license agreement. An e-mail will be dispatched to the legal contact within your company for approval to contribute to this open source project. If the request is denied or a response is not receieved within 14 days, the pull request will be rejected. If approved, it will then be reviewed by VMware. Please close this window.

[vmwclabot]

@jagajaga, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

[vmwclabot]

@jagajaga, VMware has approved your signed contributor license agreement.

[rasendubi]

What is the status of this?

[rawtaz]

@vmwareopenvmtools Can you please take a look at this? Apparently there's a patch in #33 that solves this issue.