Skip to content

booster: update to 0.13.#61221

Open
autom4il wants to merge 1 commit into
void-linux:masterfrom
autom4il:booster-0.13
Open

booster: update to 0.13.#61221
autom4il wants to merge 1 commit into
void-linux:masterfrom
autom4il:booster-0.13

Conversation

@autom4il

Copy link
Copy Markdown

Testing the changes

I tested the changes in this PR: YES

Local build testing

I built this PR locally for my native architecture, x86_64-glibc

@Duncaen

Duncaen commented Jun 24, 2026

Copy link
Copy Markdown
Member

Please do not close and open new PRs, you can just force push to the branch and use one PR.

@Duncaen Duncaen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is not against HEAD, you have to pull changes.

Comment thread srcpkgs/booster/template Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a comment about where you moved a variable is necessary.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the comments.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the reason why its disabled.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its should probably also make_check=no or do the tests work when you run it locally with ./xbps-src -Q pkg booster?

@autom4il autom4il Jun 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test doesn't work when using ./xbps-src -Q pkg booster. I put back the comment to explain why it's disabled. I set the variable make_check to no.

@autom4il autom4il requested a review from Duncaen June 24, 2026 16:56
@autom4il autom4il force-pushed the booster-0.13 branch 2 times, most recently from 782b70a to b03d8ae Compare June 24, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants