Repository navigation
New package: rom-properties-2.7.1 - #61235
Closed
goldenslumbers1 wants to merge 2 commits into
Closed
goldenslumbers1 wants to merge 2 commits into
goldenslumbers1 wants to merge 2 commits into
Conversation
Duncaen
requested changes
Jun 28, 2026
Duncaen
left a comment
Duncaen
left a comment
Member
There was a problem hiding this comment.
Please indent inside variables with one space instead of tabs.
Change the commit title to follow https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes.
Duncaen
requested changes
Jun 28, 2026
| revision=1 | ||
| build_style=cmake | ||
| configure_args="-DQT_MAJOR_VERSION=6 | ||
| -DCMAKE_BUILD_TYPE=Release |
Member
There was a problem hiding this comment.
The cmake build style sets the build type to None which is done so that xbps-src flags are respected, this shouldn't be overwritten.
Author
|
Hi, I have attempted to correct everything as you said, hopefully it suffices. I also tested the package again with the corrections applied. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission for the rom-properties shell extension.
I disabled BUILD_XFCE since some of the GTK2 dependencies it needs weren't packaged, but despite the name this does not affect its compatibility with current Thunar, only with legacy GTK2 Thunar.
Testing the changes
New package
Local build testing