Repository navigation
Do not automatically add package.json #18
Description
see workflow job
2 files changed, 13 insertions(+)
create mode 100644 package.json
create mode 100644 pnpm-lock.yaml
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Priority
None yet
Activity
fengmk2 commentedon Mar 22, 2026
Do you only need node and pnpm under https://github.com/mymx2/starter-gradle/tree/main/docs? If so, I need to look into supporting the default directory path for executing
vp install.Because setup-vp defaults to executing in the root directory, it automatically adds package.json.
fengmk2 commentedon Mar 22, 2026
You can refer to https://github.com/langgenius/dify/blob/main/.github/actions/setup-web/action.yml#L12
mymx2 commentedon Mar 22, 2026
Yes, the project only needs a Node environment and doesn’t require automatically adding a
package.jsonfile.mymx2 commentedon Jul 8, 2026
run-install defaults to true, so vp install runs in the workspace root regardless of whether a manifest exists there.
I think defaulting to false would be more appropriate because:
Principle of least surprise — An action named "setup" should set up the tool, not also install project dependencies. Comparable actions like actions/setup-node and actions/setup-java don't auto-install dependencies either.
Non-destructive by default — With the current default, vp install creates files on disk (package.json, pnpm-lock.yaml) even when no manifest exists. This is a side effect that can pollute repositories and lead to unintended commits.
Easy opt-in — Users who want the convenience can simply add run-install: true. The current behavior of requiring an explicit run-install: false in every workflow is error-prone and easy to miss.
Of course, this is a breaking change, so it would need to be part of a major version bump. Just wanted to share the feedback — happy to hear your thoughts.