feat: add Azure Pipelines integration for setup-vp#108
Conversation
Introduce a reusable Azure step template with prepare/cache/finalize lifecycle, shared portable CI primitives extracted from the GitLab runtime, and a compiled dist/azure bundle for Linux, macOS, and Windows agents. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f84c28dbd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f5b303fd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@naokihaba what else do we need to get this PR merged/CI run for full validation? |
|
I have finished reviewing your code. First, we need to run it on an actual Azure DevOps project. Do we happen to have an Azure DevOps project set up in our company that we could use? |
|
I've reviewed the latest changes and everything looks good, so I'm happy to approve them. As for the next steps, the maintainers first need to approve the GitHub Actions workflows for this fork. It looks like the test workflows are currently paused because they're waiting for approval. Once all the standard CI checks pass, we'll move on to running integration tests on Ubuntu, macOS, and Windows using the actual Azure DevOps project. At the same time, I'd like to run some smoke tests in GitLab CI just to make sure the refactoring of the common CI hasn't caused any regressions or other issues. Once all these checks are complete and we've cleared any other reviews or merge criteria, we should be all set to merge. |
|
@naokihaba Alright sounds good thanks a lot. I would love to help with Azure validation but I am not allowed to give access to our Azure stuff, but still happy to help. |
Summary
azure/setup-vp.yml) with Bash and PowerShell bootstraps for Linux/macOS and Windows agents.src/ci/*and keep the GitLab runtime as thin adapters over that layer.src/azure/*,dist/azure/index.mjs) withprepare/finalizephases around AzureCache@2, including cross-platform SFW support and logging-command adapters.rfcs/azure-pipelines-integration.mdand extend README/AGENTS/CI smoke coverage.Test plan
vp run typecheckvp run test(306 tests)vp run checkvp run buildbash -n azure/bootstrap.sh gitlab/bootstrap.shazure/bootstrap.ps1dist/azure/index.mjsinvalid-phase failure)dist/index.mjs)ubuntu-latest,macOS-latest, andwindows-latest(release-blocking follow-up)Notes
plans/was intentionally excluded from this PR.