chore: make "Disable Windows Defender" step non-blocking in E2E workflow#1397
Merged
chore: make "Disable Windows Defender" step non-blocking in E2E workflow#1397
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Agent-Logs-Url: https://github.com/voidzero-dev/vite-plus/sessions/d8e90bc7-7681-48a8-a308-f15ec0de0caf Co-authored-by: fengmk2 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix scheduled E2E test run failure
fix: make "Disable Windows Defender" step non-blocking in E2E workflow
Apr 16, 2026
fengmk2
changed the title
fengmk2
approved these changes
Apr 16, 2026
cpojer
approved these changes
Apr 16, 2026
The render_help_doc_appends_documentation_footer test was TTY-dependent: when stdout is a terminal, render_heading wraps 'Documentation:' in ANSI bold+blue codes via should_style_help(), breaking the substring match. Strip ANSI from the output so the assertion is environment-independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled E2E run failed because the "Disable Windows Defender" PowerShell step errored, causing all subsequent steps to be skipped. This is a performance optimization, not a prerequisite.
continue-on-error: trueto both "Disable Windows Defender" steps in.github/workflows/e2e-test.yml(build job and e2e-test job)