Skip to content

feat(pm): add ci subcommand#2082

Open
forehalo wants to merge 6 commits into
voidzero-dev:mainfrom
forehalo:feat/pm-ci
Open

feat(pm): add ci subcommand#2082
forehalo wants to merge 6 commits into
voidzero-dev:mainfrom
forehalo:feat/pm-ci

Conversation

@forehalo

@forehalo forehalo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

close #1389

Copilot AI review requested due to automatic review settings July 7, 2026 06:49
@netlify

netlify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 016c289
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a4f38cb0e81a0000844ee61

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new vp pm ci subcommand to support CI-friendly “clean install” flows by forwarding to the underlying package manager, along with CLI parsing tests and snapshot updates (closes #1389).

Changes:

  • Introduces vp pm ci clap subcommand and dispatch wiring in vite_pm_cli.
  • Implements PackageManager::run_ci_command / resolve_ci_command in vite_install.
  • Updates CLI help snapshot fixture to include the new subcommand and its help output.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/vite_pm_cli/src/handlers.rs Routes PmCommands::Ci to PackageManager::run_ci_command and marks it as requiring a project.
crates/vite_pm_cli/src/cli.rs Adds pm ci subcommand definition plus parsing tests.
crates/vite_install/src/commands/mod.rs Exposes the new ci command module.
crates/vite_install/src/commands/ci.rs Implements the ci command resolution/execution per package manager.
crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/cli_helper_message/snapshots/cli_helper_message.md Updates help output snapshots to include vp pm ci.
crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/cli_helper_message/snapshots.toml Adds snapshot step to capture vp pm ci -h.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/vite_install/src/commands/ci.rs
Comment thread crates/vite_install/src/commands/ci.rs
forehalo and others added 3 commits July 7, 2026 17:04
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Yii <forehalo@gmail.com>
@fengmk2

fengmk2 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Need to add a set of snapshot tests to cover the package managers supported by this command, ensuring that the behavior of this command is correct under different pm.

@forehalo

forehalo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Need to add a set of snapshot tests to cover the package managers supported by this command, ensuring that the behavior of this command is correct under different pm.

added

@fengmk2

fengmk2 commented Jul 9, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d4aaddca7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_install/src/commands/ci.rs Outdated
Comment thread crates/vite_install/src/commands/ci.rs Outdated
Comment thread crates/vite_install/src/commands/ci.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: ci (clean-install) subcommand

3 participants