feat(pm): add ci subcommand#2082
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
Pull request overview
Adds a new vp pm ci subcommand to support CI-friendly “clean install” flows by forwarding to the underlying package manager, along with CLI parsing tests and snapshot updates (closes #1389).
Changes:
- Introduces
vp pm ciclap subcommand and dispatch wiring invite_pm_cli. - Implements
PackageManager::run_ci_command/resolve_ci_commandinvite_install. - Updates CLI help snapshot fixture to include the new subcommand and its help output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/vite_pm_cli/src/handlers.rs | Routes PmCommands::Ci to PackageManager::run_ci_command and marks it as requiring a project. |
| crates/vite_pm_cli/src/cli.rs | Adds pm ci subcommand definition plus parsing tests. |
| crates/vite_install/src/commands/mod.rs | Exposes the new ci command module. |
| crates/vite_install/src/commands/ci.rs | Implements the ci command resolution/execution per package manager. |
| crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/cli_helper_message/snapshots/cli_helper_message.md | Updates help output snapshots to include vp pm ci. |
| crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/cli_helper_message/snapshots.toml | Adds snapshot step to capture vp pm ci -h. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yii <forehalo@gmail.com>
|
Need to add a set of snapshot tests to cover the package managers supported by this command, ensuring that the behavior of this command is correct under different pm. |
added |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d4aaddca7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
close #1389