Skip to content

test(snapshots): upgrade failing npm 10 fixtures - #2604

Open
fengmk2 wants to merge 6 commits into
mainfrom
fix/npm10-migration-peer-resolver
Open

test(snapshots): upgrade failing npm 10 fixtures#2604
fengmk2 wants to merge 6 commits into
mainfrom
fix/npm10-migration-peer-resolver

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Most snapshot failures use npm 10. Upgrade only those npm fixtures to npm@11.13.0.

Rename the version-specific cases and update their snapshots. Keep the npm 10 cases that passed. Remove legacy-peer-deps=true from the migration fixture.

@netlify

netlify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 07c8497
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a9a505afedc250008f26fb9

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 4, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
07c8497 2026-09-04T05:00:40.044Z View logs ↗
  • Build: Failed ❌

View logs ↗
7fdbd83 2026-09-04T04:51:09.203Z View logs ↗
  • Build: Failed ❌

View logs ↗
0efe927 2026-09-04T04:04:22.186Z View logs ↗
  • Build: Failed ❌

View logs ↗
1a0a9ae 2026-09-04T03:32:23.363Z View logs ↗
  • Build: Failed ❌

View logs ↗
dbd9357 2026-09-04T03:15:22.333Z View logs ↗
  • Build: Failed ❌

View logs ↗
9fb24ab 2026-09-04T02:14:22.148Z View logs ↗
  • Build: Failed ❌

View logs ↗
e46024e 2026-09-04T01:55:46.640Z View logs ↗

@fengmk2 fengmk2 self-assigned this Sep 4, 2026
@fengmk2
fengmk2 requested review from cpojer and wan9chi September 4, 2026 02:08
@fengmk2
fengmk2 force-pushed the fix/npm10-migration-peer-resolver branch from e46024e to 9fb24ab Compare September 4, 2026 02:13
@fengmk2 fengmk2 changed the title fix(migrate): avoid npm 10 peer resolver crash test(migrate): isolate npm 10 peer resolution Sep 4, 2026
@fengmk2 fengmk2 changed the title test(migrate): isolate npm 10 peer resolution test(snapshots): upgrade failing npm 10 fixtures Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants