Set properties dynamically (useful for lyrics, composer etc)#18
Open
xidb wants to merge 2 commits intovoltraco:masterfrom
Open
Set properties dynamically (useful for lyrics, composer etc)#18xidb wants to merge 2 commits intovoltraco:masterfrom
xidb wants to merge 2 commits intovoltraco:masterfrom
Conversation
Author
|
I also made a support for UTF filenames. |
|
@xidb Your PR looked like something I might be interested in as I need dynamic properties as well, but when I try and build this on OSX, I get the same errors the Travis CI build does. Did you ever do more work on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Superb lib you have here, it helped me a lot.
But it lacks ability to set custom tags, like lyrics.
So i removed all code, that was implicitly setting things like album artist or bpm and added a piece, where those things saved dynamically. It checks and skips if current iteration is not an common tag (artist, title).
I checked for .mp3, .m4a files and i can confirm that lyrics added that way are showing up in iTunes or other software (ffmpeg, mediainfo, tagscanner).
I think it will also with an issue you have where there was a question about grouping field.