-
Notifications
You must be signed in to change notification settings - Fork 131
chore[array]: fill_null remove compute entry point
#6437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Isaacs <[email protected]>
Merging this PR will degrade performance by 18.28%
Performance Changes
Comparing Footnotes
|
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
fill_null(array, scalar)fill_null remove compute entry point
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Benchmarks: Random AccessSummary
Detailed Results Table
|
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Benchmarks: CompressionSummary
Detailed Results Table
|
Does this PR closes an open issue or discussion?
What changes are included in this PR?
Cleaned & deprecated up the
fill_nullcompute function, replaced with ArrayBuiltins.What is the rationale for this change?
How is this change tested?
Are there any user-facing changes?
#[deprecated(note = "use array.fill_null(scalar) via ArrayBuiltins instead")]