Implement ReduceNode for ScalarFnArray to avoid boxing#6435
Implement ReduceNode for ScalarFnArray to avoid boxing#6435robert3005 merged 4 commits intodevelopfrom
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Signed-off-by: Robert Kruszewski <github@robertk.io>
9884413 to
bb3af6e
Compare
| } | ||
| } | ||
|
|
||
| impl ReduceNode for ArrayRef { |
There was a problem hiding this comment.
I have a followup that maybe lets us remove this
There was a problem hiding this comment.
We do need this just like we need impl Array for Arc<dyn Array>
There was a problem hiding this comment.
When do we pull the trigger on Array vtable that lets us access &self within the Arc.
It should come with a lot of performance
joseph-isaacs
left a comment
There was a problem hiding this comment.
There is a horrible naming in the trait
fix #6436