Use Scalar directly for constant array metadata inlining
#6439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
changed the title
Scalar directly for constant array metadata inlining
connortsui20
commented
Feb 11, 2026
Comment on lines
+53
to
+54
| /// Currently, scalars are **always** stored in a separate buffer, regardless of if we inline a | ||
| /// small scalar into the metadata. |
Contributor
Author
There was a problem hiding this comment.
See PR description above also.
We should be able to modify the visitor to just check if the scalar size is too big? But that could potentially be error-prone?
Signed-off-by: Connor Tsui <[email protected]>
Contributor
|
The problem is that you need this scalar in two places almost always. We were debating having a constant pool in the file to support batching all the constant array buffers |
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
gatesn
approved these changes
Feb 11, 2026
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the metadata for
ConstantArraytoOption<Scalar>.#6363 added functionality for inlining the constant scalar if it was small enough in the array metadata. This change adds to that by using a scalar directly for this. It is optional since we do not always want to do this.
Tests incoming!
Also, I think it is worth considering if we should not write the scalars to the buffers if we make this optimization. As is, this is doing double work.