fix(dict): cap max_dict_bytes at the u32 range BinaryView addresses - #9690
Conversation
Fixes vortex-data#9687 Signed-off-by: Antoine Dupuis <1048669+mnshdw@users.noreply.github.com>
810759b to
4d7d1a5
Compare
Signed-off-by: Antoine Dupuis <1048669+mnshdw@users.noreply.github.com>
Head branch was pushed to by a user without write access
Signed-off-by: Antoine Dupuis <1048669+mnshdw@users.noreply.github.com>
1246c5f to
c3be1a5
Compare
Merging this PR will degrade performance by 14.43%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | subtract_shapes_neon[(128, PerRowPerRow)] |
1.9 µs | 3.9 µs | -50.93% |
| ❌ | WallTime | add_shapes_neon[(128, PerRowPerRow)] |
1.9 µs | 3.2 µs | -41.24% |
| ❌ | WallTime | multiply_shapes_neon[(128, PerRowPerRow)] |
2 µs | 2.9 µs | -31.53% |
| ❌ | Simulation | cached_indices_i128[0.01] |
48 µs | 61.6 µs | -22.08% |
| ❌ | WallTime | add_constant_shapes_neon[(16384, PerRowNullableConstant)] |
10 µs | 12.2 µs | -18.05% |
| ❌ | WallTime | add_i64_nonnull_neon |
9.8 µs | 11.4 µs | -14.42% |
| ❌ | WallTime | add_u32_nonnull_neon |
6.7 µs | 7.7 µs | -13.32% |
| ❌ | WallTime | add_constant_shapes_neon[(16384, ConstantPerRow)] |
9.2 µs | 10.6 µs | -12.74% |
| ❌ | WallTime | add_constant_shapes_neon[(16384, PerRowConstant)] |
9.3 µs | 10.5 µs | -12.02% |
| ❌ | WallTime | add_shapes_neon[(16384, PerRowPerRow)] |
9.8 µs | 11.1 µs | -11.73% |
| ❌ | WallTime | words_gather_dispatch_avx512[1024] |
8 ns | 9 ns | -11.11% |
| ❌ | WallTime | subtract_shapes_neon[(16384, PerRowPerRow)] |
9.9 µs | 11.1 µs | -10.85% |
| ❌ | WallTime | mul_u32_nonnull_neon |
8.1 µs | 9.1 µs | -10.09% |
| ⚡ | Simulation | cached_indices_i32[0.01] |
51.6 µs | 37.5 µs | +37.36% |
| ⚡ | WallTime | arrow_checked_add_u32_avx2[16384] |
21.3 µs | 17.7 µs | +20.23% |
| ⚡ | WallTime | mul_u32_nonnull_avx512 |
6.4 µs | 5.8 µs | +10.86% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mnshdw:fix/dict-max-bytes-u32-overflow (c3be1a5) with develop (8edd88f)
Footnotes
-
206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
Limit
max_dict_bytestou32::MAXso the builder can never be asked for a bound it cannot address