Editorial: queue a task in NavigationPreloadManager#1834
Open
monica-ch wants to merge 2 commits into
Open
Conversation
…dManager The enable(), disable(), setHeaderValue(), and getState() methods resolved/rejected their promises directly from an 'in parallel' block. Wrap the promise-touching steps in a Queue a task on the responsible event loop. Refs: w3c#1740
Per @yoshisatoyanagisawa: keep the registration lookup, active worker null-check, and navigation-preload flag/header set/unset in the parallel block (atomic operations, safe from parallel context). Only wrap the promise-resolution and promise-rejection steps in Queue a task. Matches the pattern already used by getState().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to navigation-preload-manager-enable, navigation-preload-manager-disable, navigation-preload-manager-setheadervalue, and navigation-preload-manager-getstate.
All four methods resolved/rejected their promises directly from an "in parallel" block, which violates the "don't touch JS objects from parallel" rule. Wrap the promise-touching steps in a
Queue a taskon the responsible event loop.This is part 2/6 of #1740. Split out from #1755 for focused review.
Preview | Diff