Editorial: serialize CacheStorage access on a dedicated parallel queue#1838
Open
monica-ch wants to merge 1 commit into
Open
Editorial: serialize CacheStorage access on a dedicated parallel queue#1838monica-ch wants to merge 1 commit into
monica-ch wants to merge 1 commit into
Conversation
…arallel queue Introduce a dedicated parallel queue on the name to cache map and route CacheStorage.match / has / open / delete / keys through it, so that reads and writes on the shared map (across CacheStorage objects in different documents/workers) are serialized. Also queue-a-task for all promise resolutions to avoid touching JS objects from the parallel queue. Refs: w3c#1740, w3c#1831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to cache-storage-match, cache-storage-has, cache-storage-open, cache-storage-delete, and cache-storage-keys.
Two issues addressed:
CacheStorageobjects across documents/workers share the same underlying map, so ad-hoc "in parallel" blocks that iterate and mutate the map could race. Introduce a dedicatedname to cache map parallel queueon the map and route all five methods through it so reads and writes are serialized.Queue a taskon the promise's responsible event loop.This is part 6/6 of #1740. Also closes #1831 (duplicate). Split out from #1755 for focused review.
Preview | Diff