Add git rev-parse completions - #291
Conversation
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.
Powered by Oz
|
Addressed the same-repository issue requirement: I created #292 and linked it from this PR with |
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR adds a git rev-parse command signature with an optional variadic revision argument and wires it to the existing branch, commit, and tag generators.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Summary
git rev-parsesignature with an optional variadic revision argumentgit.jsonsignature structureCloses #292.
Closes warpdotdev/warp#12319.
Testing
./script/presubmit(format, clippy, 76 tests, and doc tests)Screenshot
The completion menu shows the current branch, local and remote branches, a commit, and a tag for
git rev-parse.