Skip to content

Add git read-tree completions - #296

Open
rasitakyol wants to merge 1 commit into
warpdotdev:mainfrom
rasitakyol:rasitakyol/gh12321-git-read-tree
Open

Add git read-tree completions#296
rasitakyol wants to merge 1 commit into
warpdotdev:mainfrom
rasitakyol:rasitakyol/gh12321-git-read-tree

Conversation

@rasitakyol

@rasitakyol rasitakyol commented Jul 19, 2026

Copy link
Copy Markdown

Summary

  • Add completions for git read-tree.
  • Cover the documented read-tree flags, including prefix/index-output and submodule controls.
  • Reuse the existing branch, remote branch, ref, and tag generators for the optional variadic tree-ish argument.

Linked issues

Closes #297

Upstream request: warpdotdev/warp#12321

Testing

  • ./script/presubmit
  • cargo test -p warp-command-signatures --lib (66/66)
  • git diff --check
  • Manually verified git read-tree <Tab> in a local Warp build using this checkout.

Screenshot

Warp showing git read-tree branch completions from the local command-signatures build

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 19, 2026
@rasitakyol
rasitakyol marked this pull request as ready for review July 19, 2026 07:53
@oz-for-oss

oz-for-oss Bot commented Jul 19, 2026

Copy link
Copy Markdown

@rasitakyol

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasitakyol

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

Powered by Oz

@rasitakyol

Copy link
Copy Markdown
Author

Addressed the same-repository issue requirement: I created #297 and updated this PR to link it with Closes #297, while retaining warpdotdev/warp#12321 as the upstream request.

Issue #297 is now undergoing Oz triage and awaiting the maintainer-applied ready-to-implement label. I will re-trigger /oz-review once that readiness gate is satisfied.

@acarl005

acarl005 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

/oz-review

@acarl005 acarl005 self-assigned this Aug 5, 2026
@oz-for-oss

oz-for-oss Bot commented Aug 5, 2026

Copy link
Copy Markdown

@acarl005

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a git read-tree command signature with options and a variadic tree-ish argument generator.

Concerns

  • The option list does not cover all valid documented git read-tree forms: --recurse-submodules is missing its optional =<checkout> value, and --exclude-per-directory <gitignore> is omitted entirely.
  • No security concerns found in this JSON-only command-signature change.
  • No approved spec context was provided for additional implementation-vs-spec validation.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

}
},
{
"name": "--recurse-submodules",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] git read-tree accepts --recurse-submodules[=<checkout>]; add an optional argument for the =<checkout> form so valid submodule-control completions are not omitted.

],
"description": "Suppress feedback messages"
}
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] The documented --exclude-per-directory <gitignore> option is missing from this options array, so the new signature does not cover the available read-tree flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add git read-tree completions

2 participants