feat: add evidence-backed false-positive rules to review-pr skill - #46
Draft
captainsafia wants to merge 1 commit into
Draft
feat: add evidence-backed false-positive rules to review-pr skill#46captainsafia wants to merge 1 commit into
captainsafia wants to merge 1 commit into
Conversation
Derived from human overrides of the review bot on recent warp-server code PRs (via the update-pr-review workflow). Adds three review-precision rules: - Do not treat generated files (*.gen.go, generated headers) as hand-maintained; codegen renames are intended output, not defects. - Verify a state-dependent bug is reachable given current control flow and existing global safeguards before flagging; downgrade hypothetical-future concerns to optional defense-in-depth suggestions. - Trace the viewer/principal-scoped entry path and domain invariants before asserting an authorization/data-scoping security hole; raise unverified concerns as open questions instead of inline CRITICAL/IMPORTANT assertions. These improve precision without weakening genuine security/correctness checks. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refines the shared
review-prskill using real reviewer feedback aggregated by theupdate-pr-reviewworkflow over the recent warp-server PR window. The analysis surfaced recurring cases where humans overrode the review bot (oz-for-oss/warp-dev-github-integration) as false positives, while its security/correctness findings (shell injection, error leakage, lock races) were consistently validated and addressed — so this change targets precision, not weakening genuine checks.Changes
Adds three evidence-backed bullets to the Review Scope section:
*.gen.go/ generated-header files as hand-maintained; renamed identifiers are intended codegen output. (Evidence: warp-server #13249, maintainer:@captainsafia— "This isn't actually a real issue. This is the types generator...")@johnturcoo.)🚨/⚠️assertions. (Evidence: #13184 ×3, reviewer@yuanben-warp.)Notes
review-specis intentionally unchanged.review-prskill lives here incommon-skills(migrated out ofwarp-server); theupdate-pr-reviewworkflow that produced this analysis still lives inwarp-server.cc @captainsafia
Conversation: https://staging.warp.dev/conversation/88890f9f-352d-4594-840c-a75b2db92c33
Run: https://oz.staging.warp.dev/runs/019f94a4-1135-79f6-b922-a465ed938d40
This PR was generated with Oz.