Conversation
acarl005
commented
Feb 12, 2026
| .unwrap_or_else(|| dwrite_font.family_name()) | ||
| .ok() | ||
| .flatten() | ||
| .unwrap_or_else(|| dwrite_font.family_name().unwrap_or_default()) |
Author
There was a problem hiding this comment.
Eh I don't love the unwrap_or_default here. This should probably return a Result too but AFAICT getting the full name from an existing Font struct is for displaying the the user and for that purpose an empty string seems fine. That's all we use it for:
vorporeal
approved these changes
Feb 12, 2026
src/sources/directwrite.rs
Outdated
Comment on lines
118
to
121
| return Handle::Memory { | ||
| bytes: Arc::new(vec![]), | ||
| font_index: 0, | ||
| }; |
There was a problem hiding this comment.
is this the right fallback? should we be propagating up an error?
Author
There was a problem hiding this comment.
Ah! We definitely should be propagating the error. Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on my work in warpdotdev/dwrote-rs#2 this PR migrates to the new methods.