CI: give the macOS tests job timeout headroom (25m → 40m, macOS only) - #14753
Closed
warp-agent-staging[bot] wants to merge 1 commit into
Closed
CI: give the macOS tests job timeout headroom (25m → 40m, macOS only)#14753warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
`Run MacOS tests` shared a 25m job timeout with Linux and Windows. macOS is compile-bound and had no headroom under that cap (p95 25.1m), so 8.5% of macOS executions were cancelled with "exceeded the maximum execution time of 25m0s" over 2026-07-28 → 2026-08-05 (18/211). Linux (p90 13.8m) and Windows (p90 17.6m) hit 0% under the same cap. Move `timeout-minutes` onto the matrix so macOS gets 40m while Linux and Windows keep 25m, so a genuine hang there is still caught. Co-Authored-By: Warp <agent@warp.dev>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run MacOS testsin.github/workflows/ci.ymlhit the job-leveltimeout-minutes: 25ceiling on 18/211 = 8.5% of executions over 2026-07-28 → 2026-08-05, whileRun Linux testsandRun Windows testshit it 0/211 = 0% under the same shared cap.GitHub does not surface these as conclusion
timed_out— they land ascancelledwith the check-run annotation "The job has exceeded the maximum execution time of 25m0s", which is why they read as generic CI flake.Root cause: macOS simply has no headroom under a 25m cap.
The long pole is the
Compile testsstep (cargo nextest --no-run): p50 8.7m / p90 12.4m / max 15.5m. It is not one hung test, and it is not the nextest 60s per-test slow-timeout tracked separately in CODE-1748.Change: move
timeout-minutesfrom thetestsjob onto the matrix entries so it can be scoped per OS — macOS gets 40m, Linux and Windows keep 25m. Raising only macOS means a genuine hang on Linux/Windows is still caught by the tighter cap.At 40m the measured macOS p95 (25.1m) sits at ~63% of the cap, satisfying the ticket's "p95 ≤ ~80% of the cap" criterion.
This PR also drops a dangling comment at the end of the
testsjob that described the old single job timeout; the rationale now lives inline on each matrix entry.Before / after expectation (re-measurable):
Run MacOS testsjob-timeout rate 8.5% → ~0%, with Linux/Windows staying at 0%. Re-measure by sampling recent Warp CI runs and countingRun MacOS testsjobs whose conclusion iscancelledat the configured cap.Out of scope (follow-up)
Compile testswall time (ticket Solution item 2). Deliberately not attempted here. Onnamespace-profile-mac-cithe workflow already skipsSwatinem/rust-cacheand usesnamespacelabs/nscloud-cache-actionwith the persistentrust+brewcaches, andPopulate Build Cachere-runs this same workflow onmaster. Without per-run cache hit-rate data there is no concrete defect to fix, so changing that path would be speculative CI restructuring rather than a contained improvement.Linked Issue
APP-5196
Testing
Testing-exempt category:
config-only. This changes only CI workflow configuration. A regression test could assert nothing beyond the literal YAML value it would be reading back, so it would detect no logic defect and would break on any future retune. Per the ticket's own testing note, validation here is a config check plus a green macOS CI run, not an in-repo unit test.What was validated instead:
actionlint v1.7.7on.github/workflows/ci.ymlreports the same 8 findings before and after this change — all pre-existingunknown runner labelwarnings for the repo's custom runners (ubuntu-latest-large,windows-latest-large), none introduced here. In particulartimeout-minutes: ${{ matrix.timeout_minutes }}validates:matrixis an allowed context for job-leveltimeout-minutes.Run MacOS tests17m46s,Run Linux tests15m25s,Run Windows tests15m17s. Atimeout-minutesexpression that failed to resolve to a valid integer is a workflow validation error that would have prevented thetestsjob from starting at all, so all three entries running proves the per-OS values took effect (40 / 25 / 25).tagsinput warning fromtrunk-io/analytics-uploader, Homebrew tap-trust notices, shell version notices)..config/nextest.tomlis untouched — the 60s per-test slow-timeout is unchanged, as intended.This is a headless CI-configuration change with no user-visible surface, so no UI verification applies.
Agent Mode
Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785969478020779