[Completions] Bump command-signatures to 2f4472ee - #14770
Closed
warp-agent-staging[bot] wants to merge 2 commits into
Closed
[Completions] Bump command-signatures to 2f4472ee#14770warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Picks up the tcpdump completion spec (warpdotdev/command-signatures#305), the client-side half of APP-3966. Co-Authored-By: Warp <agent@warp.dev> Co-Authored-By: Warp Agent <agent@warp.dev>
acarl005
enabled auto-merge (squash)
August 6, 2026 02:31
…d-signatures-tcpdump # Conflicts: # Cargo.lock # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
warp-command-signaturesfrom5e08807cto2f4472eeso the client picks up the newtcpdumpcompletion spec. This is the client-side half of APP-3966; the spec itself merged in warpdotdev/command-signatures#305.Merged PRs
That is the only spec this bump delivers.
2f4472eeis the direct child of5e08807c, so the diff between the two revs is exactly warpdotdev/command-signatures#305 and nothing else.The diff is 3 lines — the
revinCargo.tomland the two matchingsourcelines inCargo.lock. The two revs have identical dependency manifests (verified withgit diff 5e08807c 2f4472ee -- Cargo.toml '*/Cargo.toml', empty), so no other lockfile entry legitimately changes. As on the previous bumps,cargo update -p warp-command-signaturesre-resolves a dozen unrelated transitive references (windows-sys,windows-core,base64downgrades); that churn is not attributable to this bump, so the lockfile carries the targetedsourceedit instead.cargo metadata --lockedpasses, confirming the lockfile is consistent.Why not
main's headcommand-signatures
mainhas since moved on to50fe37c1("Complete just completions: Justfile recipe generator", #307). This PR deliberately stops at2f4472eeso it delivers only its own ticket's change; thejustspec should ride its own bump, the way openssl did in #14771.Verification
tcpdumpnow resolves through the completer path. Exercisedwarp_command_signatures::signature_by_name("tcpdump")anddynamic_command_signature_data()— the two callsCommandRegistry::new_with_embedded_signatures()makes incrates/warp_completer/src/signatures/legacy/mod.rs— against the new rev withdefault-features = false, features = ["embed-signatures"], matching whatwarp_completerenables on non-wasm:An unknown command still resolving to
Noneconfirms embedded data is genuinely being read, and the old-pin result is the before/after showing this bump is what delivers the signature. Re-run after the merge with master, against master's current5e08807cpin.cargo metadata --locked— clean../script/format --check— clean.cargo clippy -p warp_completer --locked --all-targets -- -D warnings— clean.cargo check -p warp_completer --locked— clean.cargo test -p warp_completer --locked— 138 passed, 25 failed. Those 25 failures are pre-existing and unrelated: stashing this change and re-running the identical command on cleanmasterproduces the byte-identical138 passed; 25 failed. They stem from a single-crate test run not pulling inwarp_features/test-utilthe way a workspace run does. Not introduced here.No regression test. A dependency-version bump is a testing-exempt category under
factory-verification— a test here could only assert the new rev string, not detect a logic defect. The client-side resolution check above is the meaningful proof, and it is a genuine before/after.The workspace-wide
./script/presubmitwas deliberately not run — disproportionate to a manifest-only pin touching no Rust source, and CI covers it.No GUI/computer-use proof: this is a dependency pin, and the
tcpdumpspec is signature data rather than a rendered surface. The journalctl precedent ([Completions] Bump command-signatures to a2ad4bfb #14742) shipped the same way.Conflict resolution
mastermoved toc11b6b98under this branch when #14771 bumped the same pin to5e08807cfor the openssl spec, which put this PR in a conflicting state. Resolved by merging currentmasterin and keeping this branch's forward move on the three conflicting lines (all the same pin), so the net diff againstmasteris only5e08807c→2f4472ee. Nothing #14771 brought in was clobbered, and all checks above were re-run after the merge. The changelog framing was also corrected: this PR previously claimed to deliver openssl and bun as well, but both reached the client via #14771, so onlytcpdumpremains.CHANGELOG-IMPROVEMENT: Added completions for
tcpdump, including capture interfaces for-iand users for-Z.Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785980450.964609
Conversation: https://staging.warp.dev/conversation/2c02c743-e687-4176-9a7d-77cab1072d4b
Run: https://oz.staging.warp.dev/runs/019fd4c2-8186-77cb-9fc2-607b21a615d4
This PR was generated with Oz.