Skip to content

ci: add Lighthouse audits on pull requests#192

Merged
avivkeller merged 2 commits into
webpack:mainfrom
ryzrr:feat/lighthouse-ci
Jul 21, 2026
Merged

ci: add Lighthouse audits on pull requests#192
avivkeller merged 2 commits into
webpack:mainfrom
ryzrr:feat/lighthouse-ci

Conversation

@ryzrr

@ryzrr ryzrr commented Jul 19, 2026

Copy link
Copy Markdown
Member

Summary
Adds the Lighthouse CI

What kind of change does this PR introduce?
CI

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?
No

Use of AI
Yes - for making it robust

Copilot AI review requested due to automatic review settings July 19, 2026 17:33
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 20, 2026 5:54am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread .github/workflows/lighthouse.yml Fixed
Comment thread .github/workflows/lighthouse.yml Outdated
on:
pull_request:
branches: [main]
types: [labeled]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have this run automaticaly, right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can have it run automatically

@@ -0,0 +1,78 @@
name: Leave Comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was adopted from https://github.com/nodejs/nodejs.org/blob/main/.github/workflows/leave-comment.yml? Can you add a comment so we know to reference that workflow

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , I have used the nodeJS workflow here, and sure will be referencing this workflow

Comment thread .github/workflows/lighthouse.yml Outdated
Comment on lines +24 to +27
- name: Harden Runner
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
with:
egress-policy: audit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, it's a Node.js-ism

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, dropping it

Copilot AI review requested due to automatic review settings July 20, 2026 05:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ryzrr ryzrr changed the title ci: add Lighthouse audits on labeled PRs ci: add Lighthouse audits on pull requests Jul 20, 2026
Comment thread .github/workflows/lighthouse.yml
@avivkeller
avivkeller merged commit 88c694e into webpack:main Jul 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants