fix(ui): Move NavBar to dedicated component folder and make it sticky#194
Open
moshams272 wants to merge 1 commit into
Open
fix(ui): Move NavBar to dedicated component folder and make it sticky#194moshams272 wants to merge 1 commit into
moshams272 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
approved these changes
Jul 20, 2026
Member
|
Seems fine to me, just note that this Navbar wasn't designed to be sticky, iirc, cc @ovflowd |
bjohansebas
approved these changes
Jul 21, 2026
bjohansebas
left a comment
bjohansebas
left a comment
Member
There was a problem hiding this comment.
Hmm, it feels a bit strange to me now that it's sticky. I personally prefer when websites don't implement sticky navbar, but that's just my opinion. If you all think it should be sticky, then go for it.
Contributor
Author
What about Hide/Show on Scroll Navbar?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the NavBar component sticky in top.