Conversation
zebot
added
the
ok-to-test
The page mixed API names, configuration keys and Haskell constructor names for the same settings, and used `searchVisibility` for the team search visibility value although that is the name of the team feature that only allows an admin to change it. Use the API and configuration names throughout, with a mapping table to the code names at the end. Also: - state that the team search visibility does not affect exact-handle search - state that `teamSearchVisibility` sets the default of the feature, not a default search visibility - describe `setSearchSameTeamOnly` as a query-time override that also restricts exact-handle search and handle lookup - document the team role (`partner` cannot search), per-user searchability, searchers without a team, and `POST /list-users` / `HEAD /handles`
mastaab
force-pushed
the
docs/searchability-naming
branch
from
September 30, 2026 20:35
3d44faf to
132675c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page mixed API names, configuration keys and Haskell constructor names for the same settings, and used
searchVisibilityfor the team search visibility value although that is the name of the team feature that only allows an admin to change it.Use the API and configuration names throughout, with a mapping table to the code names at the end. Also:
teamSearchVisibilitysets the default of the feature, not a default search visibilitysetSearchSameTeamOnlyas a query-time override that also restricts exact-handle search and handle lookuppartnercannot search), per-user searchability, searchers without a team, andPOST /list-users/HEAD /handlesChecklist
changelog.d