Skip to content

fix: umlauts in folder names [WPB-22692]#20744

Merged
e-maad merged 3 commits intodevfrom
fix/unlauts-in-folder-name-WPB-22692
Mar 18, 2026
Merged

fix: umlauts in folder names [WPB-22692]#20744
e-maad merged 3 commits intodevfrom
fix/unlauts-in-folder-name-WPB-22692

Conversation

@e-maad
Copy link
Contributor

@e-maad e-maad commented Mar 18, 2026 •
edited by github-actions bot
Loading

BugWPB-22692 [Web] Folders created on iOS with Umlaut (ü ä ö) are not correctly displayed on Web

Pull Request

Summary

Handled umlauts properly in folder names

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)

Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

thisisamir98
thisisamir98 previously approved these changes Mar 18, 2026
View reviewed changes
@e-maad e-maad requested review from thisisamir98 and zskhan March 18, 2026 14:42
thisisamir98
thisisamir98 previously approved these changes Mar 18, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026 •
edited
Loading

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • ✅ Passed: 10
  • ❌ Failed: 2
  • ⏭ Skipped: 2
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • ⏱ Total Runtime: 543.1s (~ 9 min 3 sec)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/backupRestoration-TC-8634.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Setting up new device with a backup (tags: TC-8634, crit-flow-web)

@e-maad e-maad enabled auto-merge March 18, 2026 14:51
zskhan
zskhan previously approved these changes Mar 18, 2026
View reviewed changes
@e-maad e-maad dismissed stale reviews from zskhan and thisisamir98 via 83b4aa3 March 18, 2026 15:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 18, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@e-maad e-maad added this pull request to the merge queue Mar 18, 2026
Merged via the queue into dev with commit 8f40aa7 Mar 18, 2026
86 of 89 checks passed
@e-maad e-maad deleted the fix/unlauts-in-folder-name-WPB-22692 branch March 18, 2026 15:28
e-maad added a commit that referenced this pull request Mar 18, 2026
@e-maad
fix: umlauts in folder names [WPB-22692] (#20744)
9992aa7 
* fix: umlauts in folder names [WPB-22692]

* PR feedback

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@screendriver screendriver screendriver left review comments

@zskhan zskhan zskhan approved these changes

@thisisamir98 thisisamir98 thisisamir98 left review comments

@arjita-mitra arjita-mitra Awaiting requested review from arjita-mitra arjita-mitra is a code owner

@nkaramarko nkaramarko Awaiting requested review from nkaramarko nkaramarko is a code owner

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

@V-Gira V-Gira Awaiting requested review from V-Gira V-Gira is a code owner

Assignees

No one assigned

Labels

app: webapp 👕 size: S type: bug / fix 🐞

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@e-maad @screendriver @zskhan @thisisamir98 @otto-the-bot