refactor(webapp): inject app lock crypto dependency [WPB-22420] (#20743)#20746
Merged
thisisamir98 merged 1 commit intomasterfrom Mar 18, 2026
Merged
refactor(webapp): inject app lock crypto dependency [WPB-22420] (#20743)#20746thisisamir98 merged 1 commit intomasterfrom
thisisamir98 merged 1 commit intomasterfrom
Conversation
* refactor(webapp): inject app lock crypto dependency Refactor AppLockRepository to receive its password-hashing dependency through constructor injection instead of reading libsodium directly at module scope. This keeps production behavior unchanged through a default libsodium-backed adapter, while making tests simpler and more reliable. App-lock tests now pass plain fake crypto implementations rather than using jest.mock for libsodium. Also preserve the runtime guard and upstream issue reference for the crypto_pwhash_str type mismatch, where the installed package returns a string despite the published TypeScript definitions declaring Uint8Array. * fix lint issue
thisisamir98
requested review from
V-Gira,
arjita-mitra,
e-maad,
mathias-niboulies,
nkaramarko,
otto-the-bot,
screendriver and
zskhan
as code owners
screendriver
approved these changes
Mar 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor AppLockRepository to receive its password-hashing dependency through constructor injection instead of reading libsodium directly at module scope.
This keeps production behavior unchanged through a default libsodium-backed adapter, while making tests simpler and more reliable. App-lock tests now pass plain fake crypto implementations rather than using jest.mock for libsodium.
Also preserve the runtime guard and upstream issue reference for the crypto_pwhash_str type mismatch, where the installed package returns a string despite the published TypeScript definitions declaring Uint8Array.