test(e2e): Fix broken e2e tests [WPB-22420]#20749
Merged
thisisamir98 merged 3 commits intorelease/2026-03-23from Mar 18, 2026
Merged
test(e2e): Fix broken e2e tests [WPB-22420]#20749thisisamir98 merged 3 commits intorelease/2026-03-23from
thisisamir98 merged 3 commits intorelease/2026-03-23from
Conversation
The AppLock regression came from the crypto adapter reading crypto_pwhash_OPSLIMIT_INTERACTIVE and crypto_pwhash_MEMLIMIT_INTERACTIVE before libsodium.ready resolved. That left both values undefined at runtime, so setting an app lock passcode failed with: TypeError: opsLimit cannot be null or undefined This change makes the adapter read the libsodium limits lazily after initialization, restoring app lock passcode setup and keeping the recent AppLockRepository refactor intact.
Wait for the app lock setup modal to fully close after submitting the passcode before continuing with sidebar interactions. This removes a CI race where the modal still intercepted clicks on the All conversations tab, causing TC-8639 to fail intermittently.
Add an optional history-info confirmation helper and use it in authentication re-login flows where the screen may be skipped after logging out of a temporary/public session. This fixes CI timeouts caused by waiting for the do-history-confirm button when the app correctly navigates past the history-info route.
thisisamir98
requested review from
V-Gira,
arjita-mitra,
e-maad,
mathias-niboulies,
nkaramarko,
otto-the-bot,
screendriver and
zskhan
as code owners
thisisamir98
changed the title
|
e-maad
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.