Skip to content

Update to IDF 5.5.4 - #5769

Open
netmindz wants to merge 1 commit into
wled:mainfrom
netmindz:idf_5-5-4
Open

Update to IDF 5.5.4#5769
netmindz wants to merge 1 commit into
wled:mainfrom
netmindz:idf_5-5-4

Conversation

@netmindz

@netmindz netmindz commented Aug 5, 2026

Copy link
Copy Markdown
Member

Not tested with hardware yet, but this gets the build to pass

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with the latest ESP32 software platform and toolchain.
    • Prevented potential build conflicts involving SHA1 support and time-related type definitions.
    • Updated platform components for improved compatibility with newer ESP-IDF and Arduino Core versions.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The ESP32 IDF V5 environment now uses a newer Tasmota platform with Arduino Core 3.3.8 and IDF 5.5.4. Compatibility guards were updated for __unreachable, mbedTLS SHA1 support, and time_t declarations.

Changes

ESP32 IDF V5 compatibility

Layer / File(s) Summary
ESP32 IDF V5 platform update
platformio.ini
The ESP32 IDF V5 platform changed to Tasmota 2026.05.50. The environment now defines __unreachable as __builtin_unreachable.
Library compatibility guards
wled00/mbedtls_sha1_shim.cpp, wled00/src/dependencies/time/TimeLib.h
The SHA1 shim uses MBEDTLS_SHA1_C. The fallback time_t definition also checks _TIME_T_DECLARED.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • wled/WLED#4836: Both PRs modify ESP32 PlatformIO and IDF V5 configuration.
  • wled/WLED#4838: Both PRs update ESP-IDF V5 compatibility in platformio.ini and mbedtls_sha1_shim.cpp.
  • wled/WLED#5048: Both PRs modify ESP-IDF and mbedTLS compatibility areas.

Suggested labels: V5, Awaiting testing

Suggested reviewers: willmmiles, dedehai, softhack007

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: updating the project to ESP-IDF 5.5.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
platformio.ini (1)

322-323: 🩺 Stability & Availability | 🔵 Trivial

Run hardware smoke tests for the V5 platform matrix.

This platform is inherited by all ESP32 V5 environments. Build success does not verify boot, networking, LED output, DMX, Ethernet, PSRAM, or partition behavior on hardware. Test representative board families before release.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@platformio.ini` around lines 322 - 323, Run hardware smoke tests for
representative ESP32 V5 board families using the updated platform configuration,
covering boot, networking, LED output, DMX, Ethernet, PSRAM, and partition
behavior before release.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@platformio.ini`:
- Around line 322-323: Run hardware smoke tests for representative ESP32 V5
board families using the updated platform configuration, covering boot,
networking, LED output, DMX, Ethernet, PSRAM, and partition behavior before
release.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ea93794-2e3a-4f42-ae60-7553a6d58797

📥 Commits

Reviewing files that changed from the base of the PR and between d619d46 and aa98fe4.

📒 Files selected for processing (3)
  • platformio.ini
  • wled00/mbedtls_sha1_shim.cpp
  • wled00/src/dependencies/time/TimeLib.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant