Encapsulate led.cpp's own runtime state as static, not global - #5779
Open
netmindz wants to merge 1 commit into
Open
Encapsulate led.cpp's own runtime state as static, not global#5779netmindz wants to merge 1 commit into
netmindz wants to merge 1 commit into
Conversation
5 WLED_GLOBAL variables were referenced only in led.cpp: briNlT, colNlT, lastNlUpdate, transitionActive, transitionStartTime. Converted all 5 to file-local `static`. No behavior change - purely a storage-class change. Verified: esp32dev builds and links cleanly via `pio run -e esp32dev` (1,320,323 bytes flash, no warnings from either changed file). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UtCyBD91vAYWvBzaMyQSHd
Contributor
WalkthroughThe change moves transition and nightlight runtime state from ChangesLED runtime state
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This was referenced Aug 8, 2026
DedeHai
reviewed
Aug 8, 2026
| static unsigned long transitionStartTime; | ||
| static unsigned long lastNlUpdate; | ||
| static byte briNlT = 0; // current nightlight brightness | ||
| static byte colNlT[] = { 0, 0, 0, 0 }; // current nightlight color |
Collaborator
There was a problem hiding this comment.
this will conflict my PR #5700 but not a big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of an ongoing pass identifying
WLED_GLOBALdeclarations that are actually only referenced in one file (see #5777, #5778 for earlier ones). 5 more turned out to be private toled.cpp:briNlT,colNlT,lastNlUpdate,transitionActive,transitionStartTime.Converted all 5 to file-local
static, same types and initial values as before.No behavior change — purely a storage-class change.
Test plan
esp32dev: builds and links cleanly viapio run -e esp32dev— 1,320,323 bytes flash, no warnings.wled00/,usermods/) that none of the 5 converted variables are referenced outsideled.cpp.🤖 Generated with Claude Code
Summary by CodeRabbit