reject crls with unrecognized critical extensions#10239
Open
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Open
reject crls with unrecognized critical extensions#10239gasbytes wants to merge 1 commit intowolfSSL:masterfrom
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Conversation
julek-wolfssl
requested changes
Apr 16, 2026
| WOLFSSL_MSG("\tfound optional critical flag, moving past"); | ||
| ret = GetBoolean(buf, &idx, sz); | ||
| { | ||
| int critical = 0; |
Member
There was a problem hiding this comment.
Place at start of block. Less blocks please.
Member
There was a problem hiding this comment.
What is the validity time for these CRLs? How were they generated? When will they or the certs they are signed by expire?
gasbytes
force-pushed
the
crl-idp-extension-fix
branch
from
1929fe3 to
3bee038
Compare
|
gasbytes
force-pushed
the
crl-idp-extension-fix
branch
from
3bee038 to
09e2347
Compare
Contributor
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reject crls with unrecognized critical extensions per rfc 5280 section 5.2
Fixes zd#21634
Testing
make -j8 && make check (changes includes two tests covering the appropriate involved paths)
Checklist