Merged
Conversation
Tasking compiler does not support #warning and needs the #pragma message case where available. This will fix the wolfSSH QNX nightly from failing.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates compile-time warning emission to be compatible with the Tasking compiler (which doesn’t support #warning), preventing QNX wolfSSH nightly build failures.
Changes:
- Wrap two existing
#warningdirectives insettings.hwith a compiler check. - Use
#pragma message(...)for MSVC and Tasking as a fallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
JacobBarthelmeh
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tasking compiler does not support #warning and needs the #pragma message case where available. This will fix the wolfSSH QNX nightly from failing. Similar fix to PR #10225.
Testing
The test for the QNX build of wolfSSH.
Checklist