ARM cryptoCell: improve (de)initialization logic - #11266
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Improves ARM CC310 CryptoCell init/free sequencing by tracking a single initialized state and adding cleanup on failure paths.
Changes:
- Replace enable reference counting with a single
cc310_initializedguard. - Add rollback/cleanup on
SaSi_LibInit/CRYS_RndInitfailures. - Guard
cc310_Free()so it only deinitializes when initialized.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
holtrop-wolfssl
force-pushed
the
f-11241
branch
from
August 25, 2026 19:35
e699a16 to
a15e859
Compare
holtrop-wolfssl
force-pushed
the
f-11241
branch
2 times, most recently
from
August 26, 2026 19:19
ed14a0c to
6696a4f
Compare
Fixes F-11241
holtrop-wolfssl
force-pushed
the
f-11241
branch
from
August 26, 2026 19:19
6696a4f to
80e51cf
Compare
Contributor
Author
|
retest this please (job removed) |
Contributor
Author
|
retest this please (Unable to get pull request builder trigger!!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ARM cryptoCell: improve (de)initialization logic
Fixes F-11241
Testing
How did you test?
Checklist