Fix: Unchecked buffer overrun when adding Cert Directory - #11269
Open
aidankeefe2022 wants to merge 1 commit into
Open
Fix: Unchecked buffer overrun when adding Cert Directory#11269aidankeefe2022 wants to merge 1 commit into
aidankeefe2022 wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
requested changes
Aug 25, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11269
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
|
Can one of the admins verify this patch? |
aidankeefe2022
force-pushed
the
fenrir-10736
branch
from
August 25, 2026 21:36
b40314c to
82fa3ed
Compare
wolfSSL-Fenrir-bot
requested changes
Aug 25, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11269
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
aidankeefe2022
force-pushed
the
fenrir-10736
branch
from
August 25, 2026 22:06
82fa3ed to
07ccf09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a check to make sure buffer cannot be over run by an extra long directory path.
Fenrir fix: https://fenrir.wolfssl.com/finding/10736
Testing
Made a test that loads string of correct size and one of correct size + 1.
Checklist