Conversation
Contributor
Greptile SummaryThis PR adds missing authentication method literals to two type union definitions in the user-management interfaces. It extends Key observations:
Confidence Score: 5/5
Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class AuthenticationMethod {
<<union type>>
SSO
Password
Passkey
AppleOAuth
BitbucketOAuth
DiscordOAuth ✨
GitHubOAuth
GitLabOAuth
GoogleOAuth
IntuitOAuth ✨
LinkedInOAuth
MicrosoftOAuth
SalesforceOAuth
SlackOAuth ✨
VercelMarketplaceOAuth ✨
VercelOAuth
XeroOAuth ✨
MagicAuth
CrossAppAuth
ExternalAuth ✨
MigratedSession ✨
Impersonation
}
class AuthMethod {
<<union type>>
cross_app_auth ✨
external_auth
impersonation
magic_code
migrated_session
oauth
passkey
password
sso
unknown
}
class AuthenticationResponse {
+User user
+string organizationId?
+string accessToken
+string refreshToken
+Impersonator impersonator?
+AuthenticationMethod authenticationMethod?
+string sealedSession?
+OauthTokens oauthTokens?
}
class Session {
+string id
+string userId
+AuthMethod authMethod
+SessionStatus status
+string expiresAt
}
AuthenticationResponse --> AuthenticationMethod
Session --> AuthMethod
Last reviewed commit: 6d614c1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of the authentication methods that the API supports were not included in the types here; adding them
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.