Skip to content

chore: Add DX as Codeowners#1514

Merged
gjtorikian merged 2 commits intomainfrom
add-dx-codeowners
Mar 5, 2026
Merged

chore: Add DX as Codeowners#1514
gjtorikian merged 2 commits intomainfrom
add-dx-codeowners

Conversation

@workos-sdk-automation
Copy link
Contributor

Summary

  • Adds @workos/dx team as code owners for the repository

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@workos-sdk-automation workos-sdk-automation bot requested a review from a team as a code owner March 5, 2026 20:30
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 5, 2026

Greptile Summary

This PR adds the @workos/dx team as codeowners for the repository. However, it does so by adding a new * @workos/dx rule on a separate line after the existing * @workos/typescript rule. Due to how GitHub processes CODEOWNERS files (last matching rule wins), this effectively replaces @workos/typescript as the code reviewer rather than adding @workos/dx alongside them.

Key changes:

  • .github/CODEOWNERS: Adds a new * @workos/dx rule on a separate line — this unintentionally makes @workos/dx the sole codeowner for all files, silently dropping @workos/typescript from review requirements.

To fix: Consolidate both teams onto a single line: * @workos/typescript @workos/dx

Confidence Score: 2/5

  • Not safe to merge as-is — the change unintentionally removes @workos/typescript as required reviewers due to CODEOWNERS last-match-wins semantics.
  • The intent is to add @workos/dx alongside the existing TypeScript team, but placing both teams on separate * lines means only the last rule (@workos/dx) takes effect. The TypeScript team will silently stop receiving review requests for all files in the repo. This is a logic error that requires fixing the CODEOWNERS file to list both teams on a single line.
  • .github/CODEOWNERS — the duplicate * glob pattern needs to be consolidated onto a single line.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pull Request opened] --> B{Match CODEOWNERS rules}
    B --> C["Rule 1: * @workos/typescript"]
    B --> D["Rule 2: * @workos/dx (last match)"]
    C -->|Overridden| E[❌ @workos/typescript NOT notified]
    D -->|Last rule wins| F[✅ @workos/dx notified]

    G["Intended fix: * @workos/typescript @workos/dx"] --> H[✅ @workos/typescript notified]
    G --> I[✅ @workos/dx notified]
Loading

Last reviewed commit: 86856e9

* @workos/typescript

# DX Team
* @workos/dx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last matching rule overrides earlier rules in CODEOWNERS

In GitHub's CODEOWNERS format, when multiple patterns match the same file, the last matching rule wins. Because * @workos/dx appears after * @workos/typescript, the DX team replaces the TypeScript team as codeowners for all files — rather than adding them alongside. This means pull requests will only request a review from @workos/dx, not @workos/typescript.

To make both teams co-owners, they should be listed together on a single line:

Suggested change
* @workos/dx
* @workos/typescript @workos/dx

This is the standard way to assign multiple teams as codeowners for the same glob pattern. See GitHub docs on CODEOWNERS.

@gjtorikian gjtorikian changed the title Add DX as Codeowners chore: Add DX as Codeowners Mar 5, 2026
@gjtorikian gjtorikian merged commit 2745627 into main Mar 5, 2026
8 checks passed
@gjtorikian gjtorikian deleted the add-dx-codeowners branch March 5, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants