Optimize spatial query result reuse - #476
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7669f44ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Review scope: these spatial-query APIs are new and unreleased, and breaking changes are explicitly acceptable. Do not recommend preserving the removed allocating overloads. Please focus on runtime correctness, collection and handle lifetime, query-stack balance, filtering behavior, and allocation retention. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2939413515
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * ArrayList. The initial-capacity constructor avoids dense-list growth when a set is required. | ||
| */ | ||
| public class SparseSet<T:> | ||
| public class SparseSet<T:> extends Table |
There was a problem hiding this comment.
Because class members are public by default, extending Table exposes mutators such as flush(), saveInt(), and removeInt() on every SparseSet. For example, set.flush() now erases the sparse membership index without clearing dense, so size() and get() still report elements while has() returns false, and a later add() can insert duplicates. Keep the Table as private composed storage or otherwise prevent these inherited operations from bypassing the set invariant.
AGENTS.md reference: AGENTS.md:L54-L56
Useful? React with 👍 / 👎.
1 participant
Summary
Review scope
Validation
grill typecheck --quietgrill test --quiet