Fix wavedash dev for Ruffle and JsDos engines#25
Conversation
The dev command incorrectly required `entrypoint()` (which only reads from [custom].entrypoint) for Ruffle and JsDos engines. This caused "Engine config requires an entrypoint" errors for valid Ruffle/JsDos configs. Now mirrors the build push logic: Custom uses entrypoint(), Ruffle/JsDos use executable_entrypoint_params(). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
8793c17 to
100f8c5
Compare
|
Claude finished @cloud9c's task in 1m 2s —— View job Code Review
Fix is correct and well-scoped. The root cause analysis in the PR description is accurate: the original code called Change 1 —
|
Summary
wavedash devfailed with "Engine config requires an entrypoint" for Ruffle and JsDos projectsentrypoint()for all three engine types (Custom, JsDos, Ruffle), butentrypoint()only reads from[custom].entrypointentrypoint()for Custom engines; for Ruffle/JsDos, passexecutable_entrypoint_params()instead — matching the existingbuild pushlogicTest plan
wavedash devfrom a project with a[ruffle]config — should launch dev server without errorwavedash devfrom a project with a[jsdos]config — should work similarlywavedash devfrom a project with a[custom]config — should still require entrypoint as before🤖 Generated with Claude Code